From: Jonas Ådahl <jadahl@gmail.com>
Date: Mon, 15 Aug 2022 16:23:27 +0000 (+0200)
Subject: dialog: Remove incorrect disconnectObject()
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~241
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=7f4db052a0b36f5409baac4f80c58550b9689d5a;p=gnome-shell.git

dialog: Remove incorrect disconnectObject()

It was added, as there was a previous signal disconnect in this
function, but it happened to be dead code, and the disconnectObject()
call was added in error. Remove it.

Fixes: 26235bbe5433c48b81bd3917aaf9ef14ff1929b2
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1349>
---

diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index 1ae27a134..414a3e4c7 100644
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -60,8 +60,6 @@ class Dialog extends St.Widget {
     }
 
     makeInactive() {
-        this._parentActor.disconnectObject(this);
-
         this.buttonLayout.get_children().forEach(c => c.set_reactive(false));
     }